Skip to content

Release api_core 1.6.0#6769

Merged
crwilcox merged 4 commits intomasterfrom
release-api_core-1.6.0
Dec 3, 2018
Merged

Release api_core 1.6.0#6769
crwilcox merged 4 commits intomasterfrom
release-api_core-1.6.0

Conversation

@crwilcox
Copy link
Contributor

This pull request was generated using releasetool.

@crwilcox crwilcox requested a review from theacodes as a code owner November 30, 2018 20:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2018
@tseaver
Copy link
Contributor

tseaver commented Nov 30, 2018

CI failure is for nox -e pytype.

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2018
@crwilcox
Copy link
Contributor Author

crwilcox commented Dec 3, 2018

@rchen152 is looking into PyType failures a bit. Locally I have some different failures on runs.

crwilcox@redrover ~/w/r/g/api_core> nox -s pytype                                                                                                                                                                    release-api_core-1.6.0
nox > Running session pytype
nox > Creating virtualenv using python3.6 in /Users/crwilcox/workspace/releasetool/google-cloud-python/api_core/.nox/pytype
nox > pip install --upgrade . grpcio >= 1.8.2 grpcio-gcp >= 0.2.2 pytype >= 2018.9.26
nox > pytype
Analyzing 53 sources with 0 dependencies
ninja: Entering directory `/Users/crwilcox/workspace/releasetool/google-cloud-python/api_core/pytype_output'
ninja: error: build.ninja:29: multiple rules generate /Users/crwilcox/workspace/releasetool/google-cloud-python/api_core/pytype_output/pyi/google/api_core/path_template.pyi [-w dupbuild=err]

nox > Command pytype  failed with exit code 1
nox > Session pytype failed.

The error varies each run which is a bit unusual.

ninja: error: build.ninja:44: multiple rules generate /Users/crwilcox/workspace/releasetool/google-cloud-python/api_core/pytype_output/pyi/google/api_core/timeout.pyi [-w dupbuild=err]
ninja: error: build.ninja:47: multiple rules generate /Users/crwilcox/workspace/releasetool/google-cloud-python/api_core/pytype_output/pyi/google/api_core/grpc_helpers.pyi [-w dupbuild=err]

@rchen152
Copy link
Contributor

rchen152 commented Dec 3, 2018

@crwilcox It looks like what's happening is that pytype is somehow finding multiple files named path_template.py (and timeout.py and grpc_helpers.py - the error probably differs because it varies which file pytype discovers first). The other thing I noticed is that the file count in the status message ("Analyzing 53 sources with 0 dependencies") differs from the one I see (28 sources). Any idea why there might be two copies of some source files?

EDIT: if there are two files with the same name in different directories, this may be google/pytype#198.

@crwilcox
Copy link
Contributor Author

crwilcox commented Dec 3, 2018

@rchen152 , I rm -rf'd the output dir (pytype_output) between runs so that is probably related?

@crwilcox crwilcox merged commit 24b6ec6 into master Dec 3, 2018
@jmdobry jmdobry deleted the release-api_core-1.6.0 branch December 5, 2018 07:34
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants