Skip to content

Comments

Firestore: prevent use of transforms as values passed to 'Query.where'.#6703

Merged
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:6699-firestore-query_where_w_transforms
Nov 30, 2018
Merged

Firestore: prevent use of transforms as values passed to 'Query.where'.#6703
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:6699-firestore-query_where_w_transforms

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 29, 2018

Closes #6699.

@tseaver tseaver added the api: firestore Issues related to the Firestore API. label Nov 29, 2018
@tseaver tseaver requested a review from crwilcox as a code owner November 29, 2018 21:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Nov 29, 2018

The Kokoro failure is in an unrelated flaky systest ("Quota exceeded").

@tseaver
Copy link
Contributor Author

tseaver commented Nov 29, 2018

@crwilcox This one should also be ready for review.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2018
@tseaver tseaver merged commit 4fe89c9 into googleapis:master Nov 30, 2018
@tseaver tseaver deleted the 6699-firestore-query_where_w_transforms branch November 30, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants