Firestore: add support for 'ArrayRemove' / 'ArrayUnion' transforms#6651
Merged
tseaver merged 6 commits intogoogleapis:masterfrom Nov 27, 2018
tseaver:6546-firestore-array_remove-array_union
Merged
Firestore: add support for 'ArrayRemove' / 'ArrayUnion' transforms#6651tseaver merged 6 commits intogoogleapis:masterfrom tseaver:6546-firestore-array_remove-array_union
tseaver merged 6 commits intogoogleapis:masterfrom
tseaver:6546-firestore-array_remove-array_union
Conversation
6 tasks
mcdonc
approved these changes
Nov 27, 2018
Contributor
mcdonc
left a comment
There was a problem hiding this comment.
It's a big PR but I understand the component parts, and it looks good to me.
In preparation for adding 'ArrayUnion' / 'ArrayRemove' transforms, which are not constants. See: #6551.
Adds missing values to an array field.
FBO adding 'ArrayRemove', which is functionally identical (only the class docstring will vary).
Removes values from an array field.
Contributor
Author
|
Rebased after merge of #6559. Will merge when CI is green. |
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #6559 as a base. Please review that one first.Closes #6546.