Firestore: refactor 'Document.get' to use the 'GetDocument' API.#6534
Merged
tseaver merged 1 commit intogoogleapis:masterfrom Nov 27, 2018
tseaver:6533-firestore-document-get-api
Merged
Firestore: refactor 'Document.get' to use the 'GetDocument' API.#6534tseaver merged 1 commit intogoogleapis:masterfrom tseaver:6533-firestore-document-get-api
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:6533-firestore-document-get-api
Conversation
tseaver
commented
Nov 15, 2018
tseaver
commented
Nov 15, 2018
| firestore_api.get_document.return_value = response | ||
| client, document = _make_client_document(firestore_api, testcase) | ||
|
|
||
| document.get() # No '.textprotos' for errors, field_paths. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
6 tasks
Contributor
Author
|
@crwilcox, @theacodes I still can't see the Kokoro test log, which means I can't diagnose anything. System tests, unit tests, and lint are all passing on my local machine for ade1acf. |
Contributor
Author
|
@crwilcox, @theacodes CI is green after manually forcing it to rebuild via the |
Contributor
Author
|
@crwilcox, @JustinBeckwith, @theacodes Can one of you please paste the Kokoro error log into a gist? My suspicion is that the failure is due to #6605. |
Update conformance test to actually run for 'get'. Toward #6533.
mcdonc
approved these changes
Nov 27, 2018
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Update conformance test to actually run for 'get'. Toward #6533.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update conformance test to actually run for 'get'.
Toward #6533.