Skip to content

Comments

Import stdlib ABCs from 'collections.abc' rather than 'collections'.#6451

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:6450-api_core-core-bigquery-firestore-py38-collections
Nov 12, 2018
Merged

Import stdlib ABCs from 'collections.abc' rather than 'collections'.#6451
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:6450-api_core-core-bigquery-firestore-py38-collections

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 8, 2018

On Python 2.7, fall back to 'collections'.

Closes #6450.

@tseaver tseaver added api: bigquery Issues related to the BigQuery API. api: core api: firestore Issues related to the Firestore API. type: cleanup An internal cleanup or hygiene concern. labels Nov 8, 2018
@tseaver tseaver requested review from crwilcox and theacodes November 8, 2018 18:02
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2018
On Python 2.7, fall back to 'collections'.

Closes #6450.
@tseaver tseaver merged commit f99f625 into googleapis:master Nov 12, 2018
@tseaver tseaver deleted the 6450-api_core-core-bigquery-firestore-py38-collections branch November 12, 2018 19:06
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. api: core api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. type: cleanup An internal cleanup or hygiene concern.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants