Implementing `BlobKeyProperty` in `ndb`. by dhermes · Pull Request #6445 · googleapis/google-cloud-python

dhermes · 2018-11-07T20:38:54Z

No description provided.

ndb/src/google/cloud/ndb/blobstore.py

 ]


+BlobKey = _ports.BlobKey


ndb/src/google/cloud/ndb/blobstore.py

+MAX_BLOB_FETCH_SIZE = 1015808
+UPLOAD_INFO_CREATION_HEADER = "X-AppEngine-Upload-Creation"
+
+BlobKeyProperty = model.BlobKeyProperty


ndb/src/google/cloud/ndb/_ports.py

+
+
+@functools.total_ordering
+class BlobKey:


ndb/src/google/cloud/ndb/_ports.py

+from google.cloud.ndb import exceptions
+
+
+_MAX_STRING_LENGTH = 1500


ndb/src/google/cloud/ndb/_ports.py

+    .. note::
+
+        The blobstore was an early Google App Engine feature that later became
+        Google Cloud Storage.


ndb/src/google/cloud/ndb/_ports.py

+                )
+        elif blob_key is not None:
+            raise exceptions.BadValueError(
+                "blob key should be a string; received "


chrisrossi · 2018-11-12T16:47:27Z

This looks good to me for the most part. I'm still struggling with understanding why we need it.

I also wonder if, instead of _ports, we should we try to find true homes for anything we're having to hoover in from somewhere else, rather than a catchall. In this case, we could put BlobKey next to BlobKeyProperty in model or we could start our own _datastore_types module.

This is a port from `google.appengine.api.datastore_types` in the SDK.

dhermes · 2018-11-13T17:55:34Z

I think you're right about the _datastore_types module, so am doing a rename.

dhermes added the api: ndb label Nov 7, 2018

dhermes assigned chrisrossi Nov 7, 2018

dhermes requested a review from chrisrossi November 7, 2018 20:38

dhermes requested a review from crwilcox as a code owner November 7, 2018 20:38

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2018

dhermes commented Nov 7, 2018

View reviewed changes

chrisrossi reviewed Nov 7, 2018

View reviewed changes

dhermes force-pushed the ndb-add-BlobKeyProperty branch 2 times, most recently from a327b40 to 28b2155 Compare November 8, 2018 23:10

chrisrossi reviewed Nov 12, 2018

View reviewed changes

dhermes added 3 commits November 13, 2018 09:53

Adding BlobKey to ndb.

15b06a5

This is a port from `google.appengine.api.datastore_types` in the SDK.

Adding BlobKeyProperty to ndb.

6ae7b46

Updating blobstore to reflect BlobKey updates.

76c4b24

dhermes added 2 commits November 13, 2018 09:59

Renaming _ports to _datastore_types.

f91a81d

Changing "a string" to "bytes".

bf152fa

dhermes force-pushed the ndb-add-BlobKeyProperty branch from 28b2155 to bf152fa Compare November 13, 2018 17:59

chrisrossi approved these changes Nov 13, 2018

View reviewed changes

dhermes merged commit 6b43d49 into googleapis:master Nov 13, 2018

dhermes deleted the ndb-add-BlobKeyProperty branch November 13, 2018 19:52

chrisrossi pushed a commit to chrisrossi/google-cloud-python that referenced this pull request Feb 22, 2019

Implementing BlobKeyProperty in ndb. (googleapis#6445)

44ac257

parthea pushed a commit that referenced this pull request Nov 24, 2025

Implementing BlobKeyProperty in ndb. (#6445)

7e50c76

		from google.cloud.ndb import exceptions


		_MAX_STRING_LENGTH = 1500



		@functools.total_ordering
		class BlobKey:

Conversation

dhermes commented Nov 7, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

chrisrossi commented Nov 12, 2018

Uh oh!

dhermes commented Nov 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants