Implementing `GeoPtProperty` in `ndb`. by dhermes · Pull Request #6432 · googleapis/google-cloud-python

dhermes · 2018-11-07T01:19:19Z

In the process also:

Adding google.cloud.ndb._ports to bring in "necessary" classes from the GAE standard SDK

This is incomplete for now but I wanted to send it so I didn't forget the comments I had about the implementation.

ndb/src/google/cloud/ndb/_ports.py

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Ported implementations from the Google App Engine SDK.


ndb/src/google/cloud/ndb/_ports.py

+        return "datastore_types.GeoPt({!r}, {!r})".format(self.lat, self.lon)
+
+    def __str__(self):
+        return "{},{}".format(self.lat, self.lon)


ndb/src/google/cloud/ndb/model.py

            property.
-        validator (Callable[[Property, Any], bool]): A validator to be used
-            to check values.
+        validator (Callable[[~google.cloud.ndb.model.Property, Any], bool]): A


ndb/src/google/cloud/ndb/_ports.py

+
+
+@functools.total_ordering
+class GeoPt:


ndb/src/google/cloud/ndb/_ports.py

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Ported implementations from the Google App Engine SDK.


ndb/src/google/cloud/ndb/_ports.py

+        Returns:
+            str: The repr for this instance.
+        """
+        return "datastore_types.GeoPt({!r}, {!r})".format(self.lat, self.lon)


Using `GeoPoint` from `google-cloud-datastore`.

dhermes added the api: ndb label Nov 7, 2018

dhermes assigned chrisrossi Nov 7, 2018

dhermes requested a review from chrisrossi November 7, 2018 01:19

dhermes requested a review from crwilcox as a code owner November 7, 2018 01:19

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2018

dhermes commented Nov 7, 2018

View reviewed changes

ndb/src/google/cloud/ndb/model.py

property.

validator (Callable[[Property, Any], bool]): A validator to be used

to check values.

validator (Callable[[~google.cloud.ndb.model.Property, Any], bool]): A

This comment was marked as spam.

Sign in to view

dhermes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 7, 2018

chrisrossi reviewed Nov 7, 2018

View reviewed changes

ndb/src/google/cloud/ndb/_ports.py Outdated Show resolved Hide resolved

dhermes commented Nov 7, 2018

View reviewed changes

chrisrossi reviewed Nov 7, 2018

View reviewed changes

ndb/src/google/cloud/ndb/_ports.py Outdated

Returns:

str: The repr for this instance.

"""

return "datastore_types.GeoPt({!r}, {!r})".format(self.lat, self.lon)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes force-pushed the ndb-add-GeoPtProperty branch from 0223f6e to ccc98d1 Compare November 7, 2018 17:13

dhermes removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 7, 2018

dhermes force-pushed the ndb-add-GeoPtProperty branch 2 times, most recently from a4437de to 8331456 Compare November 7, 2018 18:58

dhermes added 3 commits November 7, 2018 10:58

Adding GeoPt class for ndb.

fe0299e

Implementing GeoPtProperty.

87cfc99

Using GeoPoint from google-cloud-datastore.

4b6bc05

dhermes force-pushed the ndb-add-GeoPtProperty branch from 8331456 to 4b6bc05 Compare November 7, 2018 18:58

Adding note about GeoPt difference in MIGRATION_NOTES.

f41056f

chrisrossi approved these changes Nov 7, 2018

View reviewed changes

dhermes merged commit e3c44d8 into googleapis:master Nov 7, 2018

dhermes deleted the ndb-add-GeoPtProperty branch November 7, 2018 19:36

chrisrossi pushed a commit to chrisrossi/google-cloud-python that referenced this pull request Feb 22, 2019

Implementing GeoPtProperty in ndb. (googleapis#6432)

bf309d8

Using `GeoPoint` from `google-cloud-datastore`.

parthea pushed a commit that referenced this pull request Nov 24, 2025

Implementing GeoPtProperty in ndb. (#6432)

f39b92b

Using `GeoPoint` from `google-cloud-datastore`.

Conversation

dhermes commented Nov 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dhermes commented Nov 7, 2018 •

edited

Loading