Skip to content

Bigtable: Emulator fixes#6385

Merged
tseaver merged 5 commits intogoogleapis:masterfrom
sumit-ql:emulator-fixes
Nov 9, 2018
Merged

Bigtable: Emulator fixes#6385
tseaver merged 5 commits intogoogleapis:masterfrom
sumit-ql:emulator-fixes

Conversation

@sumit-ql
Copy link
Contributor

@sumit-ql sumit-ql commented Nov 5, 2018

This is fix for #6287

@sumit-ql sumit-ql requested a review from crwilcox as a code owner November 5, 2018 07:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2018
@sumit-ql sumit-ql changed the title Emulator fixes Bigtable: Emulator fixes Nov 5, 2018
@sumit-ql
Copy link
Contributor Author

sumit-ql commented Nov 5, 2018

@sduskis @tseaver Please review.

@sduskis sduskis added the api: bigtable Issues related to the Bigtable API. label Nov 5, 2018
@sduskis sduskis mentioned this pull request Nov 5, 2018
@sduskis
Copy link
Contributor

sduskis commented Nov 8, 2018

@sumit-ql, what's your timeline for working on this? This is blocking our next release.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 9, 2018
@alixhami alixhami removed their request for review November 9, 2018 19:14
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@sduskis sduskis added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 9, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. cla: no This human has *not* signed the Contributor License Agreement. labels Nov 9, 2018
@tseaver tseaver removed the request for review from dhermes November 9, 2018 19:15
@tseaver tseaver removed the request for review from tswast November 9, 2018 19:15
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 9, 2018
@tseaver tseaver added cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 9, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2018
@sduskis sduskis added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@tseaver tseaver merged commit 0530884 into googleapis:master Nov 9, 2018
parthea pushed a commit that referenced this pull request Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants