Skip to content

Comments

Firestore: remove use of deprecated 'channel' argument.#6271

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:firestore-avoid_deprecated_usage_in_tests
Oct 24, 2018
Merged

Firestore: remove use of deprecated 'channel' argument.#6271
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:firestore-avoid_deprecated_usage_in_tests

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 18, 2018

Use mocks and a custom iterator to bypass the underlying GAPIC client altogether.

Instead, just use mocks and a custom iterator to bypass the underlying
GAPIC client altogether.
@tseaver tseaver added testing api: firestore Issues related to the Firestore API. labels Oct 18, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 24, 2018

Merging without review: uncontroversial, testing-only change.

@tseaver tseaver merged commit 372bad1 into googleapis:master Oct 24, 2018
@tseaver tseaver deleted the firestore-avoid_deprecated_usage_in_tests branch October 24, 2018 21:22
parthea pushed a commit that referenced this pull request Nov 24, 2025
Instead, just use mocks and a custom iterator to bypass the underlying
GAPIC client altogether.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants