BigQuery: use _get_sub_prop helper so missing load stats don't raise.#6269
Merged
tseaver merged 2 commits intogoogleapis:masterfrom Oct 19, 2018
Merged
BigQuery: use _get_sub_prop helper so missing load stats don't raise.#6269tseaver merged 2 commits intogoogleapis:masterfrom
tseaver merged 2 commits intogoogleapis:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
8a34642 to
1eceb60
Compare
|
CLAs look good, thanks! |
tseaver
suggested changes
Oct 18, 2018
| return int(statistics['load']['inputFileBytes']) | ||
| return _helpers._get_sub_prop( | ||
| self._properties, ['statistics', 'load', 'inputFileBytes'] | ||
| ) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return int(statistics['load']['inputFiles']) | ||
| return _helpers._get_sub_prop( | ||
| self._properties, ['statistics', 'load', 'inputFiles'] | ||
| ) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return int(statistics['load']['outputBytes']) | ||
| return _helpers._get_sub_prop( | ||
| self._properties, ['statistics', 'load', 'outputBytes'] | ||
| ) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return int(statistics['load']['outputRows']) | ||
| return _helpers._get_sub_prop( | ||
| self._properties, ['statistics', 'load', 'outputRows'] | ||
| ) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Oct 18, 2018
Contributor
|
@dpebot merge when green, please. |
Contributor
|
Okay! I'll merge when all statuses are green and all reviewers approve. |
Contributor
|
@theacodes I have no idea why @dpebot drops the ball on this one. |
Contributor
|
@hrfuller Thanks for the patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.