Skip to content

Fix race condition where pending Ack IDs can be modified by another thread.#5929

Merged
theacodes merged 1 commit intomasterfrom
fix-ack-id-race-condition
Sep 12, 2018
Merged

Fix race condition where pending Ack IDs can be modified by another thread.#5929
theacodes merged 1 commit intomasterfrom
fix-ack-id-race-condition

Conversation

@theacodes
Copy link
Contributor

Closes #5913

@theacodes theacodes requested a review from tseaver September 11, 2018 19:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2018
@tseaver
Copy link
Contributor

tseaver commented Sep 11, 2018

I kicked off a rebuild, hoping to work around the logging systest failure.

@theacodes theacodes force-pushed the fix-ack-id-race-condition branch from c6dc8fd to 3ea88a5 Compare September 11, 2018 21:08
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Sep 11, 2018
@tseaver tseaver force-pushed the fix-ack-id-race-condition branch from 3ea88a5 to 949604c Compare September 11, 2018 22:16
@ghost
Copy link

ghost commented Sep 12, 2018

apologies if I am out of line, but will this make it into the 0.38.0 release? (#5962)

@theacodes
Copy link
Contributor Author

Oh good catch, @jordanhurwitz! I thought this was merged.

@theacodes theacodes merged commit f074335 into master Sep 12, 2018
@theacodes theacodes deleted the fix-ack-id-race-condition branch September 12, 2018 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants