Skip to content

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Jul 24, 2018

This pull request was generated using releasetool.

Closes #5680.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2018
@theacodes theacodes requested a review from tseaver July 24, 2018 16:37
@sduskis sduskis added the api: datastore Issues related to the Datastore API. label Jul 24, 2018

### Internal / Testing Changes

- Add Test runs for Python 3.7 and remove 3.4 (#5295)

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@theacodes
Copy link
Contributor Author

theacodes commented Jul 25, 2018 via email

@tseaver
Copy link
Contributor

tseaver commented Jul 25, 2018

CI failure due to subsequent merges to master. We can ignore it, or else rebase.

@tseaver
Copy link
Contributor

tseaver commented Jul 25, 2018

@theacodes I'm not sure how the process works with merging this kind of PR and generating the appropriate tag.

@theacodes
Copy link
Contributor Author

@tseaver https://github.com/GoogleCloudPlatform/releasetool if you wanna give it a shot, you just need to run releasetool tag once this is merged.

@theacodes theacodes force-pushed the release-datastore-1.7.0 branch from 0fc3aa0 to f6b6021 Compare July 25, 2018 19:43
@tseaver tseaver merged commit 1da6012 into master Jul 26, 2018
@tseaver tseaver deleted the release-datastore-1.7.0 branch July 26, 2018 18:15
@tseaver
Copy link
Contributor

tseaver commented Jul 26, 2018

@theacodes

you just need to run releasetool tag once this is merged.

I couldn't make that work: no PR showed up in the list, and when I manually typed the PR, it crapped out:

> Please pick one of the following PRs:


Which one do you want to tag and release?: 5683
Traceback (most recent call last):
  File "../releasetool/venv/bin/releasetool", line 11, in <module>
    load_entry_point('gcp-releasetool', 'console_scripts', 'releasetool')()
  File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/tseaver/projects/agendaless/Google/src/releasetool/venv/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/tseaver/projects/agendaless/Google/src/releasetool/releasetool/main.py", line 54, in tag
    return releasetool.commands.tag.python.tag()
  File "/home/tseaver/projects/agendaless/Google/src/releasetool/releasetool/commands/tag/python.py", line 160, in tag
    determine_release_pr(ctx)
  File "/home/tseaver/projects/agendaless/Google/src/releasetool/releasetool/commands/tag/python.py", line 65, in determine_release_pr
    ctx.release_pr = pulls[pull_idx-1]
IndexError: list index out of range

So, I tagged datastore-1.7.0 and pushed it manually.

@theacodes
Copy link
Contributor Author

theacodes commented Jul 26, 2018 via email

@tseaver
Copy link
Contributor

tseaver commented Jul 26, 2018

Release published

parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants