Skip to content

Comments

Re-sync with .proto / .textproto files from google-cloud-common.#5351

Merged
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:firestore-resync_conformance_tests
May 21, 2018
Merged

Re-sync with .proto / .textproto files from google-cloud-common.#5351
tseaver merged 1 commit intogoogleapis:masterfrom
tseaver:firestore-resync_conformance_tests

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented May 21, 2018

Regenerated test_pb2.py by hacking the Makefile to work around machine- specific bits (those changes not committed).

Copied in additional .textproto files, bumping the count of testcasesfrom 83 to 236.

Still doesn't include updates to run tests for listen-*.textproto.

Regenerated 'test_pb2.py' by hacking the 'Makefile' to work around machine-
specific bits (those changes not committed).

Copied in additional '.textproto' files, bumping the count of testcases
from 83 to 236.

Still doesn't include updates to run tests for 'listen-*.textproto'.
@tseaver tseaver added testing api: firestore Issues related to the Firestore API. labels May 21, 2018
@tseaver tseaver requested a review from crwilcox May 21, 2018 18:59
@tseaver tseaver requested a review from lukesneeringer as a code owner May 21, 2018 18:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2018
@tseaver tseaver merged commit 53ef8a2 into googleapis:master May 21, 2018
@tseaver tseaver deleted the firestore-resync_conformance_tests branch May 21, 2018 19:46
parthea pushed a commit that referenced this pull request Nov 24, 2025
Regenerated 'test_pb2.py' by hacking the 'Makefile' to work around machine-
specific bits (those changes not committed).

Copied in additional '.textproto' files, bumping the count of testcases
from 83 to 236.

Still doesn't include updates to run tests for 'listen-*.textproto'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants