BigQuery: NUMERIC type support #5331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tseaver
reviewed
May 16, 2018
| { | ||
| 'sql': 'SELECT NUMERIC "123456789.123456789"', | ||
| 'expected': decimal.Decimal('123456789.123456789'), | ||
| }, |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
) * Support for BigQuery's NUMERIC type, which is currently in alpha. * Remove unused import from test_query.py. * Fix newly-added system tests; all system and unit tests pass now. Add unit tests to reach what should be 100% coverage for new code. * Fix lint warning and rename shadowed unit test. * Add unit test that NUMERIC types are encoded correctly in insert_rows
Contributor
Author
|
Rebased. |
tseaver
approved these changes
May 17, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for BigQuery's NUMERIC type.
Note that this PR was already reviewed in #4874 for when this feature was still in alpha.
Originally authored by @ElliottBrossard