Skip to content

Kokoro should run integration tests in examples #4308

Closed

Description

@igorbernstein2

The cloud bigtable examples contain integration tests. It would be nice to setup kokoro to run them:
https://github.com/googleapis/google-cloud-java/tree/master/google-cloud-examples/src/test/java/com/google/cloud/examples/bigtable

@elisheva-qlogic can you provide the mvn command line you used to run the integration tests?

Activity

  1. added
    type: processA process-related concern. May include testing, release, or the like.
    api: bigtableIssues related to the Bigtable API.
    on Jan 8, 2019
  2. elisheva-qlogic commented on Jan 9, 2019

    @elisheva-qlogic
    Contributor

    mvn clean

  3. rahulKQL commented on Apr 8, 2019

    @rahulKQL
    Contributor

    @igorbernstein2

    Do we still want to integrate these test case with kokoro? OR should we have some other set of integration test? As these basic tests are taking up to 3 mins on my local machine.

    Running com.google.cloud.examples.bigtable.ITHelloWorld
    Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 83.605 sec
    
    Running com.google.cloud.examples.bigtable.ITTableAdminExample
    Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 81.218 sec
    
    Running com.google.cloud.examples.bigtable.ITInstanceAdminExample
    Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 30.616 sec

    The command to run the integration test specific to bigtable would be:

    mvn clean verify \
     -Dtest="com.google.cloud.examples.bigtable/**" \
     -Dbigtable.project=[project id] \
     -Dbigtable.instance=[instance id]
  4. igorbernstein2 commented on Apr 30, 2019

    @igorbernstein2
    ContributorAuthor

    These should definitely run from kokoro, but they should run in parallel similar to how the integration tests run:

    https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-bigtable/pom.xml#L104-L127

  5. self-assigned this
    on May 2, 2019
  6. rahulKQL commented on Jun 4, 2019

    @rahulKQL
    Contributor

    @igorbernstein2 This issue can be closed, as with the #5215 @billyjacobson moved bigtable examples into Java-docs-samples repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the Bigtable API.type: processA process-related concern. May include testing, release, or the like.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions