Skip to content

Publisher.shutdown should return promptly #3687

Closed
#5039
Closed
Publisher.shutdown should return promptly#3687
#5039
Assignees
yoshi-automation
Labels
api: pubsubIssues related to the Pub/Sub API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Description

@pongad
pongad
opened on Sep 15, 2018

Current implementation waits for all messages to either succeed or fail before returning.

This will change the behavior of shutdown. So we should wait for awaitTermination to bake in for a while before doing this.

Activity

  1. pongad
    added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    api: pubsubIssues related to the Pub/Sub API.
    on Sep 15, 2018
  2. pongad
    added a commit that references this issue on Sep 17, 2018

    pubsub: add Publisher.awaitTermination (#3688)

    ae614b3
  3. snehashah16
    added a commit that references this issue on Sep 18, 2018

    Sync to master head (#3698)

    d9d7adc

  4. SergeyZadorozhniy commented on Nov 15, 2018

    @SergeyZadorozhniy
    SergeyZadorozhniy
    on Nov 15, 2018

    Is this issue resolved?

  5. sduskis
    closed this as completedin #5039on Apr 30, 2019
  6. JustinBeckwith
    assigned
    yoshi-automation
    on Feb 1, 2021
  7. meltsufin
    added 2 commits that reference this issue on Apr 29, 2026

    pubsub: add Publisher.awaitTermination (#3688)

    d717121

    pubsub: add Publisher.awaitTermination (#3688)

    1a6056c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: pubsubIssues related to the Pub/Sub API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions