Repository navigation
BigQuery insertAll always retries operation #3321
Description
Activity
Hi @neuromantik33,
Thanks for catching this issue! Would you mind turning your commit into a pull request? For testing, one option could be to add a unit test to
BigQueryImplTest.java, set a spy on theBigQueryOptions options(see line 274), and assert thatgetRetrySettings()is called on that spy object whenBigQueryImpl.insertAllis run or not run.- added a commit that references this issue
on Dec 3, 2018 - added a commit that references this issue
on Dec 4, 2018 - added a commit that references this issue
on Mar 9, 2026 - added 4 commits that reference this issue
on Mar 24, 2026
Hi. First time reporter here.
I wanted to report a small but perhaps inconvenient bug in BigQuery, specifically regarding streaming inserts using an
InsertAllRequest. It seems for some reason unknown to me that inserts are retried using the client'sRetrySettingswhenever row ids are supplied for deduplication.When the current implementation always attempts a retry (which I discovered during these odd retry errors) due to the fact that
Lists.transform()is strictly lazy.Anyhow the fix is minor and I corrected it on my branch but I'm unsure how to write the necessary tests in order to validate my claim. My commit is here: neuromantik33@984b5bb, and after proper review I can submit a pull request.
Thanks in advance for any feedback.