Skip to content

PubSub emulator exhibiting failures with Subscription JSON payload #2199

Closed
Closed
PubSub emulator exhibiting failures with Subscription JSON payload#2199
Assignees
garrettjonesgoogle
Labels
api: pubsubIssues related to the Pub/Sub API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@bilisie
bilisie
opened on Jun 28, 2017

Hi,

I'm testing an emulator locally using a json payload as such:

curl -H "Content-Type: application/json" -X PUT  -d '{ "name": "projects\/sample-project\/subscriptions\/subscription-localhost-2017-06-28T12-25-43-55cd2ef3-edb2-4484-9d13-55004416057e", "topic": "projects\/sample-project\/topics\/sample-topic" }' http://localhost:8080/v1/projects/sample-project/subscriptions/subscription-localhost-2017-06-28T13-09-08-88285d03-fcef-48b8-b851-a27449a47812

On the emulator side the following stack trace is being produced:

Jun 28, 2017 1:15:54 PM io.gapi.emulators.grpc.HttpAdapter$UnaryMethodHandler handle
WARNING: Failed to convert request to message: Field google.pubsub.v1.Subscription.name has already been set.
com.google.protobuf.InvalidProtocolBufferException: Field google.pubsub.v1.Subscription.name has already been set.
	at io.gapi.emulators.grpc.JsonFormat$ParserImpl.mergeField(JsonFormat.java:1383)
	at io.gapi.emulators.grpc.JsonFormat$ParserImpl.mergeMessage(JsonFormat.java:1239)
	at io.gapi.emulators.grpc.JsonFormat$ParserImpl.merge(JsonFormat.java:1197)
	at io.gapi.emulators.grpc.JsonFormat$ParserImpl.merge(JsonFormat.java:1079)
	at io.gapi.emulators.grpc.JsonFormat$Parser.merge(JsonFormat.java:283)
	at io.gapi.emulators.grpc.HttpJsonAdapter.merge(HttpJsonAdapter.java:61)
	at io.gapi.emulators.grpc.HttpAdapter$UnaryMethodHandler.handle(HttpAdapter.java:466)
	at io.gapi.emulators.grpc.HttpAdapter.handleRequest(HttpAdapter.java:165)
	at io.gapi.emulators.netty.HttpHandler.channelRead(HttpHandler.java:52)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:373)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:359)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:351)
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:373)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:359)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:351)
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:373)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:359)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:351)
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:373)
	at io.netty.channel.AbstractChannelHandlerContext.access$600(AbstractChannelHandlerContext.java:39)
	at io.netty.channel.AbstractChannelHandlerContext$7.run(AbstractChannelHandlerContext.java:364)
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:418)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:454)
	at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:873)
	at java.lang.Thread.run(Thread.java:748)

Jun 28, 2017 1:15:54 PM io.gapi.emulators.netty.HttpHandler$1 onError
INFO: Exception when handling request: INVALID_ARGUMENT: Payload isn't valid for request.

The pattern of usage of using json payloads does function properly against real endpoints.

Activity

  1. shinfan
    added
    api: pubsubIssues related to the Pub/Sub API.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Jun 28, 2017

  2. hbchai commented on Jun 30, 2017

    @hbchai
    hbchai
    on Jun 30, 2017

    Hi @bilisie, one interesting feature of your request is that you are essentially specifying the name of the subscription to be created twice; that is first in the URL, and second in the request body as "name". Moreover, the two values differ in your example curl command (although I'm assuming that's a copy-paste error).

    You are actually correct that it's not considered an error for the value to be specified twice (I just verified this by testing against the live service - the specification is a bit ambiguous about this, see https://github.com/googleapis/googleapis/blob/master/google/api/http.proto#L206), so the emulator behavior is indeed different, and we should fix that. However, note that the name specified in the request body is being ignored. You can try using a different value against the live system as a test; you should see that the name of the subscription that is created comes from the URL.

    Thanks for reporting this, BTW.

  3. bilisie commented on Jun 30, 2017

    @bilisie
    bilisie
    on Jun 30, 2017
    Author

    Hi @hbchai

    Thanks for the update. I've added better reproduction of the issue here:
    https://github.com/bilisie/pubsub-emulator-issue

    Removing the name from the URL breaks the integration tests against real PubSub as I've tested earlier. I can also try removing it from the payload or leaving it the URL to see if that satisfied both the emulator and prod.

  4. hbchai commented on Jun 30, 2017

    @hbchai
    hbchai
    on Jun 30, 2017

    The subscription name definitely needs to be specified in the URL. Please do try removing it from the payload.

  5. garrettjonesgoogle commented on Jul 17, 2017

    @garrettjonesgoogle
    garrettjonesgoogle
    on Jul 17, 2017
    Contributor

    This isn't an issue in google-cloud-java, and it looks like there is a workaround, so I am going to close it out now.

  6. garrettjonesgoogle
    closed this as completedon Jul 17, 2017
  7. garrettjonesgoogle
    added
    testing
    on Jul 17, 2017
  8. JustinBeckwith
    assigned
    garrettjonesgoogle
    on Feb 1, 2021
  9. chingor13
    added 2 commits that reference this issue on Feb 20, 2026

    deps: update dependency com.google.cloud:google-cloud-shared-dependen…

    fc8f4fb

    chore(main): release 2.41.0 (#2203)

    8a3026c
  10. suztomo
    added 2 commits that reference this issue on Mar 23, 2026

    deps: update dependency io.opentelemetry:opentelemetry-bom to v1.54.0 (…

    1776a15

    chore(main): release 2.32.3 (googleapis#2200)

    bae00c3
  11. benjaminp
    added a commit that references this issue on Jul 13, 2026

    chore: update readme file (googleapis#2199)

    55ac8a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: pubsubIssues related to the Pub/Sub API.priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions