Avoid FileReader

Noticed you're using FileReader in com.google.cloud.ServiceOptions and possibly elsewhere. This is potentially buggy because it depends on the platform default encoding and thus behavior can change from one system to the next. Instead, try an InputStreamReader with a specified encoding chained to a FileInputStream.

protected static String googleCloudProjectId() {
    File configDir;
    if (System.getenv().containsKey("CLOUDSDK_CONFIG")) {
      configDir = new File(System.getenv("CLOUDSDK_CONFIG"));
    } else if (isWindows() && System.getenv().containsKey("APPDATA")) {
      configDir = new File(System.getenv("APPDATA"), "gcloud");
    } else {
      configDir = new File(System.getProperty("user.home"), ".config/gcloud");
    }
    String activeConfig = activeGoogleCloudConfig(configDir);
    FileReader fileReader = null;
    try {
      fileReader = new FileReader(new File(configDir, "configurations/config_" + activeConfig));
    } catch (FileNotFoundException newConfigFileNotFoundEx) {
      try {
        fileReader = new FileReader(new File(configDir, "properties"));
      } catch (FileNotFoundException oldConfigFileNotFoundEx) {
        // ignore
      }
}

@elharo

@elharo Do we know that the encoding of the configuration files will always be the same?

The problem is that you can't assume it is the native encoding of the platform. I.e. there is no guarantee that FileReader() does the right thing.

You'd have to ask gcloud what character set they use.

The feature request is added to the backlog. The issue will be closed but is linked in the backlog and can continue to be used for comment and discussion.

test(deps): update dependency com.google.truth:truth to v1.4.0 (#1537)

deps: update dependency com.google.cloud:sdk-platform-java-config to …

feat: Introducing Tracing with OpenTelemetry API #1537 (#1576)

test(deps): update dependency com.google.truth:truth to v1.4.0 (googl…

deps: update dependency com.google.cloud:sdk-platform-java-config to …

chore(main): release 2.16.1 (googleapis#1534)

deps: update dependency com.google.cloud:google-cloud-storage to v2.4…

deps: update dependency org.graalvm.buildtools:junit-platform-native …

chore(main): release 2.17.0 (googleapis#1516)

Navigation Menu

Repository navigation

Avoid FileReader #1537

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Avoid FileReader #1537

Description

Activity

garrettjonesgoogle commented on Aug 10, 2017

elharo commented on Aug 10, 2017

yihanzhen commented on Jan 11, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions