Skip to content
This repository was archived by the owner on May 12, 2026. It is now read-only.

docs(samples): modified comments in the samples and minor refactor - #990

Merged
lesv merged 4 commits into
mainfrom
patch-auth-samples
Sep 13, 2022
Merged

docs(samples): modified comments in the samples and minor refactor#990
lesv merged 4 commits into
mainfrom
patch-auth-samples

Conversation

@Sita04

@Sita04 Sita04 commented Aug 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes:

  1. Modified Auth implicit sample to use GCS instead of GCE.
  2. Modified comments
  3. Minor variable value refactoring

@Sita04
Sita04 requested a review from a team August 29, 2022 08:20
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. samples Issues that are directly related to samples. labels Aug 29, 2022
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2022
piaxc
piaxc suggested changes Aug 29, 2022
View reviewed changes
Comment thread samples/snippets/src/main/java/AuthenticateImplicitWithAdc.java Outdated
Comment thread samples/snippets/src/main/java/VerifyGoogleIdToken.java Outdated
@Sita04
Sita04 requested a review from piaxc August 30, 2022 07:56
piaxc
piaxc approved these changes Aug 30, 2022
View reviewed changes

@piaxc piaxc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sita!

@lesv
lesv merged commit 669ab04 into main Sep 13, 2022
@lesv
lesv deleted the patch-auth-samples branch September 13, 2022 22:42
@release-please release-please Bot mentioned this pull request Oct 10, 2022
Merged
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 17, 2022
@release-please
chore(main): release 1.12.0 (#1050)
fda7fa4 
🤖 I have created a release *beep* *boop*
---


## [1.12.0](https://togithub.com/googleapis/google-auth-library-java/compare/v1.11.0...v1.12.0) (2022-10-14)


### Features

* Adding validation for psc endpoints ([#1042](https://togithub.com/googleapis/google-auth-library-java/issues/1042)) ([b37a565](https://togithub.com/googleapis/google-auth-library-java/commit/b37a565c6c1e7acb44baf2307c862c9df8be9345))


### Bug Fixes

* Fixed javadoc errors ([#945](https://togithub.com/googleapis/google-auth-library-java/issues/945)) ([1ddc994](https://togithub.com/googleapis/google-auth-library-java/commit/1ddc99481ae8b0f0eceb4cb442d5c6614ec8a411))


### Documentation

* **samples:** Modified comments in the samples and minor refactor ([#990](https://togithub.com/googleapis/google-auth-library-java/issues/990)) ([669ab04](https://togithub.com/googleapis/google-auth-library-java/commit/669ab042844e46d0503bbd31fd2da92a7963bad5))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@lesv lesv lesv approved these changes
@piaxc piaxc piaxc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@lesv lesv

Labels

samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sita04 @lesv @piaxc @kokoro-team