Repository navigation
[Minor] Static Code Analysis with Php Inspections (EA Extended) - #1174
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
bshaffer
left a comment
There was a problem hiding this comment.
I am happy with most of these changes, but I prefer the readability of is_null, so unless there's a good reason I'd like to keep it the way it is.
| } | ||
|
|
||
| if (is_null($cache)) { | ||
| if (null === $cache) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| $scopes = $this->prepareScopes(); | ||
| // add refresh subscriber to request a new token | ||
| if ($this->isAccessTokenExpired() && isset($token['refresh_token'])) { | ||
| if (isset($token['refresh_token']) && $this->isAccessTokenExpired()) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
|
||
| if (!empty($errors) && isset($errors[0]['reason']) && | ||
| isset($this->retryMap[$errors[0]['reason']])) { | ||
| if (!empty($errors) && isset($errors[0]['reason'], $this->retryMap[$errors[0]['reason']])) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I recently run into the "only Php talk" video and thought that supporting our community member would be a good idea =)
Tweaks found and fixed automatically by Php Inspections (EA Extended) (my pet-project):