Skip to content

removes stash logic, adds caching test for MemoryCache - #1085

Merged
bshaffer merged 5 commits into
masterfrom
remove-stash-dependency
Nov 2, 2016
Merged

bshaffer merged 5 commits into
masterfrom
remove-stash-dependency

Conversation

@bshaffer

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 20, 2016
@bshaffer

bshaffer commented Oct 20, 2016 •

Copy link
Copy Markdown
Contributor Author

Yet another way to solve #1075

This is my preferred method. That way, users can handle tedivm/stash at their own risk. However this leaves us w/o a recommended way to implement file caching.

@bshaffer
bshaffer force-pushed the remove-stash-dependency branch from 3ed35a4 to dbc0c54 Compare October 24, 2016 16:22
@tmatsuo

tmatsuo commented Oct 25, 2016

Copy link
Copy Markdown

sounds good too

@bshaffer
bshaffer merged commit f4a8ef0 into master Nov 2, 2016
@bshaffer
bshaffer deleted the remove-stash-dependency branch November 2, 2016 14:28
@mwithheld

mwithheld commented Nov 26, 2016 •

Copy link
Copy Markdown

Docs on the GitHub main page (README.md) should be updated: remove the reference to Stash, replace with an example for MemoryCache (presumably phpFastCache?). Please include a link to the MemoryCache source.

@bshaffer

Copy link
Copy Markdown
Contributor Author

Would you mind filing an issue for this and we will get the readme updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants