Thread leak issue when using RecommendationServiceClient

[iwmib]

This bug was observed in version 33.0.0 of the java lib. API version 17. JDK version 17

When calling the dismissRecommendation() method on the RecommendationServiceClient the number of active threads increases and never goes down afterward (threads are not released). See the screenshot attached.

It looks like there might be a thread leak issue.

[jradcliff]

Are you wrapping your RecommendationServiceClient in a try-with-resources Statement so it's closed when the block completes?

try (RecommendationServiceClient recommendationClient = 
       googleAdsClient.getLatestVersion().getRecommendationServiceClient()) {
  // make some requests with the client...
} // client closes when this block exits

[iwmib]

Yes, we are already wrapping the call as you showed.

[iwmib]

Actually, I was wrong. Apologies. Yes, we didn't close the service properly. Please ignore.

[jradcliff]

No worries, thanks for the prompt update!