Skip to content

If matches(x) fails but containsMatch(x) would have passed, suggest containsMatch in the failure message #791

Closed
Closed
If matches(x) fails but containsMatch(x) would have passed, suggest containsMatch in the failure message#791
Labels
P3not scheduledtype=enhancementMake an existing feature better

Description

@cpovirk
cpovirk
opened on Nov 25, 2020

Similar in spirit to #783.

assertThat("foo bar baz").matches("ba[rz]");
<normal failure message>
Did you mean to call containsMatch() instead of match()?

Activity

  1. cpovirk
    added
    P3not scheduled
    type=enhancementMake an existing feature better
    on Nov 25, 2020

  2. junyan59 commented on Mar 1, 2021

    @junyan59
    junyan59
    on Mar 1, 2021
    Contributor

    Hi @cpovirk, I made a PR for this issue #830, could you review it? Thanks.

  3. copybara-service
    closed this as completedin 7e9fc7aon Jun 27, 2024
  4. pull
    added a commit that references this issue on Jun 28, 2024

    Make StringSubject.matches suggest using containsMatch if matches(x) …

    7e9fc7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3not scheduledtype=enhancementMake an existing feature better

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions