Skip to content

Conversation

@saurabhkpatel
Copy link
Contributor

No description provided.

@dbieber
Copy link
Collaborator

dbieber commented Apr 17, 2017

There's one failing test.
https://travis-ci.org/google/python-fire/jobs/222276022

=================================== FAILURES ===================================
_______________________ FireTest.testTabCompletionNoName _______________________
self = <fire.fire_test.FireTest testMethod=testTabCompletionNoName>
    def testTabCompletionNoName(self):
      with self.assertRaises(ValueError):
>       fire.Fire(tc.NoDefaults, '-- --completion')
E       AssertionError: ValueError not raised
fire/fire_test.py:328: AssertionError

Previously this would be a value error because no name was supplied. Now sys.argv[0] is being used as the name.

@saurabhkpatel
Copy link
Contributor Author

@dbieber do you recommend to remove this test case now? I am planning to remove this test-case.
As we know that by default we are assigning name to it.

@dbieber
Copy link
Collaborator

dbieber commented Apr 18, 2017

Yep, I think removing the test sounds good. The other option would be modifying the test to check that completion works appropriately even when no name is specified.

@saurabhkpatel
Copy link
Contributor Author

saurabhkpatel commented Apr 19, 2017

Adjusted test case.

@dbieber dbieber merged commit 1f366f9 into google:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants