Fixed Issue 42: Handled another type of exception and added testcase … #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the same. I need help to resolve one pylint error
dbieber
reviewed
Apr 6, 2017
Collaborator
dbieber
left a comment
There was a problem hiding this comment.
Thanks for the pull request!
Some comments are inline.
fire/core_test.py
Outdated
| self.assertEqual(core._OneLineResult('hello'), 'hello') # pylint: disable=protected-access | ||
| self.assertEqual(core._OneLineResult({}), '{}') # pylint: disable=protected-access | ||
| self.assertEqual(core._OneLineResult({'x': 'y'}), '{"x": "y"}') # pylint: disable=protected-access | ||
| self.assertEqual(core._OneLineResult(self.createCircularRefObject()), # pylint: disable=protected-access |
Collaborator
There was a problem hiding this comment.
Let's make this a new test, "testOneLineResultCircularRef".
Let's also put
x = {}
x['y'] = x
either a) inside the test, or b) as a new component in test_components.py.
I think we should probably go w/ b so that we can reuse the component in other tests (e.g. testing completion script generation, help strings, actual use of Fire, etc).
| except (TypeError, ValueError): | ||
| return str(result).replace('\n', ' ') | ||
|
|
||
|
|
dbieber
reviewed
Apr 7, 2017
fire/core_test.py
Outdated
|
|
||
| def testOneLineResultCircularRef(self): | ||
| circular_reference = tc.CircularReference() | ||
| self.assertEqual(core._OneLineResult(circular_reference.create()),# pylint: disable=protected-access |
Collaborator
There was a problem hiding this comment.
can you add 2 spaces before the "#"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for the same. I need help to resolve one pylint error
After these changes:
Example:
output: