Skip to content

Conversation

@davidcaron
Copy link
Contributor

  • {name: David} -> {name:David} (no space)
  • reference to last example should be the third example ?

- `{name: David}` -> `{name:David}` (no space)
- reference to last example should be the third example ?
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Author has not signed CLA label Jan 27, 2020
@davidcaron
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Author has signed CLA and removed cla: no Author has not signed CLA labels Jan 27, 2020
@dbieber
Copy link
Collaborator

dbieber commented Jan 27, 2020

Good catch on the last example. Should be either '{name: David}' or {name:David}.

The reference to the last example was as intended though. "name" and "David" are "bare-words", and are treated as strings (even though they don't have quotes around them) in the dict.

@davidcaron
Copy link
Contributor Author

Got it, I reverted that change.

@dbieber dbieber merged commit 192c020 into google:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Author has signed CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants