feat: Add map image support to Rizzcharts with local placeholder #420
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
- Add local map-placeholder.png to shell public directory - Update standard_catalog/map.json with map-image component using local image - Update agent.py to instruct LLM to use local placeholder (or Google Maps API if key available) - Avoids dependency on external placehold.co service
3a51069 to
a1839f2
Compare
| # Check for Google API Key | ||
| googlemaps_api_key = os.getenv("GOOGLEMAPS_API_KEY") | ||
| if googlemaps_api_key: | ||
| map_image_instruction = f""" |
There was a problem hiding this comment.
Could you explain the need for delegating the LLM to decide whether to use Google Maps or a fall-back image?
Can we update the client side code to decide this?
One thing that catches my eye here is that the code will embed a GoogleMaps API Key inside the prompt which is preferably kept private as possible.
There was a problem hiding this comment.
Hi, @sugoi-yuzuru
I agree that embedding the API key in the prompt is a security concern and the decision should move to the client.
To enable client-side decision making, I'm considering adding a new GoogleMap component. The server would send map data (coordinates, pins), and the client would decide how to render based on API key availability. This fully addresses your concerns but requires adding a new component and extending the catalog.
Would you be okay with this approach?
Summary
This PR adds map image support to the Rizzcharts sample agent, using a local placeholder image instead of relying on external services.
Changes
map-placeholder.pngtosamples/client/lit/shell/public/map-imagecomponent using local/map-placeholder.pngpathGOOGLEMAPS_API_KEYenv var is setAffected files:
samples/client/lit/shell/public/map-placeholder.png[NEW]samples/agent/adk/rizzcharts/examples/standard_catalog/map.jsonsamples/agent/adk/rizzcharts/agent.pyVerification
Related
Addresses feedback from #396 - reviewer requested avoiding external placeholder services like placehold.co.