-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: add a new output writer and use it in t.Log #71575
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Aleks Fazlieva <[email protected]>
This PR (HEAD: 59f309a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/646956. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Arati: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Arati: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: Commit-Queue+1 Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-05T20:51:24Z","revision":"7e0a540201f0c62c2e98497ff9f853a2cfef293a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64-boringcrypto has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: Commit-Queue+1 (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-05T21:19:36Z","revision":"7e0a540201f0c62c2e98497ff9f853a2cfef293a"} Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
Message from Jonathan Amsterdam: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/646956. |
This is the first of two planned CLs. The first one introduces a new
output writer and uses it in a refactored implementation of t.Log.
This new writer maintains the formatting provided by t.Log while making
call site information optional. Additionally, it provides buffering of
input. The second CL would export a new t.Output method, refine its
implementation and add testing.
Co-authored-by: Aleks Fazlieva [email protected]
For #59928.