Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strings: Add strings.Reverse() #36913

Closed
wants to merge 2 commits into from
Closed

strings: Add strings.Reverse() #36913

wants to merge 2 commits into from

Conversation

codic12
Copy link

@codic12 codic12 commented Jan 30, 2020

Closes #36887

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Closes golang#36887
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Jan 30, 2020
@codic12
Copy link
Author

codic12 commented Jan 30, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jan 30, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 2b939d3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/217120 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@codic12 codic12 changed the title Add strings.Reverse() strings: Add strings.Reverse() Jan 30, 2020
@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/217120.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Lanre Adelowo:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/217120.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Code-Review-2

Temporary -2 until proposal is made and accepted.


Please don’t reply on this GitHub thread. Visit golang.org/cl/217120.
After addressing review feedback, remember to publish your drafts!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/217120.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 63e0080) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/217120 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gurjus Bhasin:

Patch Set 3:

(2 comments)

Patch Set 2: Code-Review-2

Temporary -2 until proposal is made and accepted.

I do not understand fully, what is a -2?


Please don’t reply on this GitHub thread. Visit golang.org/cl/217120.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gurjus Bhasin:

Patch Set 3:

Patch Set 2: Code-Review-2

Temporary -2 until proposal is made and accepted.

The proposal was made (on Github)...
IT has not been accepted though


Please don’t reply on this GitHub thread. Visit golang.org/cl/217120.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 3:

Temporary -2 until proposal is made and accepted.

I do not understand fully, what is a -2?

In the Gerrit instance that we use for code review, a -2 means that the change cannot be committed until the -2 is removed. This is standard practice for API changes, to avoid an accidental commit.


Please don’t reply on this GitHub thread. Visit golang.org/cl/217120.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gurjus Bhasin:

Patch Set 3:

Patch Set 3:

Temporary -2 until proposal is made and accepted.

I do not understand fully, what is a -2?

In the Gerrit instance that we use for code review, a -2 means that the change cannot be committed until the -2 is removed. This is standard practice for API changes, to avoid an accidental commit.

Ah okay, makes sense.


Please don’t reply on this GitHub thread. Visit golang.org/cl/217120.
After addressing review feedback, remember to publish your drafts!

@codic12
Copy link
Author

codic12 commented Feb 1, 2020

Closing in favor of sort.InvertSlice

@codic12 codic12 closed this Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: sort: add InvertSlice
3 participants