#102 - exclusive fullscreen fix/workaround#133
Closed
Matsyir wants to merge 1 commit intogkngkc:masterfrom
Closed
Conversation
Author
|
Actually getting some issues with this fix now, closing for now but the general idea is there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple workaround for #102.
The Sync functions are untested, but the Async ones work.
I wouldn't really expect this to get merged, but it seems simpler to share the fix as a PR.
The way it saves whether to switch back to exclusive fullscreen is not the most reliable, but it should work as long as only one file browser is used at once, which I imagine is most use cases.
There's probably a better way to "append" callbacks, but I don't know it and this works.