restore trailing tab for parser test_headers#9
Open
whitty wants to merge 1 commit intogitpatch-rs:mainfrom
Open
restore trailing tab for parser test_headers#9whitty wants to merge 1 commit intogitpatch-rs:mainfrom
whitty wants to merge 1 commit intogitpatch-rs:mainfrom
Conversation
also add one more test for binary differing
sourcefrog
approved these changes
Dec 8, 2025
| // see https://github.com/uniphil/patch-rs/commit/364897dae8599cdb758c00fdc8dacd1645959070 | ||
| let sample2b = "\ | ||
| --- lao | ||
| --- lao |
Collaborator
There was a problem hiding this comment.
Can I suggest instead adding a \t into the source so that it's obvious to humans and so we don't risk losing it later?
Suggested change
| --- lao | |
| --- lao\t |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also add one more test for binary differing
This pulls in a fix from the original project from uniphil/patch-rs@2e82523
I took the liberty of adding an
.editorconfigfile so that many editors will not strip the whitespace in the future.