Conversation
|
I think this is also needed to fix #2 because right now a line like |
|
What is the state of this changed? is it intended to be complete? FYI: test failures on regression patches: This is failing on the chunk header - but see below. This patch seems to be being mis-parsed possibly around the end-of-chunk detection? |
|
It seems like conceptually a good idea to make use of the counts in the headers, but I'm not really sure from the PR or a brief read of the diff which one is meant to have priority if the number of lines expected disagrees with the lines that are apparently present? |
|
Sorry for dropping the ball here. We've switched to our own fork of IIRC there were some test cases here that did not contain valid diffs which made the line counting fail :) But I might misremember! |
I started to work on this a little bit to make our parsing more robust against empty lines (e.g. when whitespace is removed) by counting the lines from the diff.