Merged
Conversation
vcsjones
approved these changes
Sep 24, 2021
ff7217a to
1dc9ca0
Compare
This PR adds a workflow to build releases: - The builds are signed on Windows. - The builds are organized into a `build` folder, to make things easier to understand and debug. - The `build` folder is uploaded as artifacts on Actions, in one collective `build.zip`. - If a tag was pushed, the build release files are individually uploaded as assets to the releases page: - Compare [`smimesign-staging@v1.1.0-rc1`](https://github.com/github/smimesign-staging/releases/tag/v1.1.0-rc1) to [`smimesign@v0.0.13`](https://github.com/github/smimesign/releases/tag/v0.0.13) and note that I've managed to keep fairly similar names and formats (e.g. `.tgz` for macOS). - Tags starting with `v` are automatically marked as releases, so the latest release will always show up on the side of https://github.com/github/smimesign (if your window is wide enough). - The version string is consistently embedded using `-ldflags` for all builds. I've directly checked that this works, using `smimesign --version` on amd64, the installer, and macOS. - We now build using Go 1.17. This PR does not add code signing for macOS, and doesn't add a build for Apple Silicon. We [recommend using Homebrew](https://github.com/github/smimesign#macos) to install `smimesign` on macOS, which works the same without signing and already builds for Apple Silicon.
1dc9ca0 to
c6ad9bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a.k.a. "Sign the
smimesign" 😃This PR adds a workflow to build releases:
buildfolder, to make things easier to understand and debug.buildfolder is uploaded as artifacts on Actions, in one collectivebuild.zip.smimesign@v0.0.13and note that I've managed to keep fairly similar names and formats (e.g..tgzfor macOS).vare automatically marked as releases, so the latest release will always show up on the side of https://github.com/github/smimesign (if your window is wide enough).-ldflagsfor all builds. I've directly checked that this works, usingsmimesign --versionon amd64, the installer, and macOS.This PR does not add code signing for macOS, and doesn't add a build for Apple Silicon. We recommend using Homebrew to install
smimesignon macOS, which works the same without signing and already builds for Apple Silicon.