Skip to content

Fix casing issue in new item value #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muan merged 2 commits into from
Dec 10, 2019
Merged

Fix casing issue in new item value #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aff5ad
Modify test to ensure casing is retained
muan Dec 10, 2019
aceb4b3
Avoid modifying query casing until substring comparison
muan Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class FilterInputElement extends HTMLElement {
async function filterResults(filterInput: FilterInputElement, checkCurrentQuery: boolean = false) {
const input = filterInput.input
if (!input) return
const query = input.value.toLowerCase()
const query = input.value.trim()
const id = filterInput.getAttribute('aria-owns')
if (!id) return
const container = document.getElementById(id)
Expand Down Expand Up @@ -124,7 +124,7 @@ async function filterResults(filterInput: FilterInputElement, checkCurrentQuery:
}

function matchSubstring(_item: HTMLElement, itemText: string, query: string): MatchResult {
const match = itemText.indexOf(query) !== -1
const match = itemText.toLowerCase().indexOf(query.toLowerCase()) !== -1
return {
match,
hideNew: itemText === query
Expand All @@ -133,7 +133,7 @@ function matchSubstring(_item: HTMLElement, itemText: string, query: string): Ma

function getText(filterableItem: HTMLElement) {
const target = filterableItem.querySelector('[data-filter-item-text]') || filterableItem
return (target.textContent || '').trim().toLowerCase()
return (target.textContent || '').trim()
}

function updateNewItem(newItem: HTMLElement, query: string) {
Expand Down
6 changes: 3 additions & 3 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ describe('filter-input', function() {
assert.equal(customEvent.detail.count, 1)
assert.equal(customEvent.detail.total, 4)

changeValue(input, 'boom')
changeValue(input, 'BB-8 robot')
assert.notOk(newItem.hidden, 'New item form should be shown')
assert.equal(newItem.querySelector('[data-filter-new-item-value]').value, 'boom')
assert.equal(newItem.querySelector('[data-filter-new-item-text]').textContent, 'boom')
assert.equal(newItem.querySelector('[data-filter-new-item-value]').value, 'BB-8 robot')
assert.equal(newItem.querySelector('[data-filter-new-item-text]').textContent, 'BB-8 robot')
})

it('filters and toggles blankslate', async function() {
Expand Down