Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: synchronize dbschemes #13302

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented May 26, 2023

This PR synchronizes the common dbscheme fragments used by C++ with other languages and adds C++ to the CI check that validates that all common fragments are identical across languages.

The most important changes to the dbscheme are:

  • svn-related tables have been dropped; these are unused by any of our QL libraries and the svn extractor no longer exists.
  • The type of the "file" column of the locations_default table is narrowed from @container to @file. As far as I know the extractor should never produce location information for "folders", so switching to @file and matching the dbscheme of all other languages felt the right way to go. If there is a good reason to allow @container locations then we can also adjust all other languages.

TODO: add mostly trivial up and downgrade scripts. The only relevant change is deleting svn tables when upgrading.

@github-actions github-actions bot added the C++ label May 26, 2023
@aibaars aibaars force-pushed the sync-dbscheme-cpp branch 2 times, most recently from 38b2647 to 46f8ba0 Compare June 6, 2023 17:50
@aibaars aibaars force-pushed the sync-dbscheme-cpp branch from 46f8ba0 to 938160b Compare June 6, 2023 17:51
@aibaars aibaars force-pushed the sync-dbscheme-cpp branch from 938160b to 333cfc8 Compare June 6, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant