Sync dbschemes #12849
Draft
Sync dbschemes #12849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the upgrade-script requirement on Go changes like |
jketema
reviewed
Apr 19, 2023
Comment on lines
+257
to
+262
| case @diagnostic.severity of | ||
| 10 = @diagnostic_debug | ||
| | 20 = @diagnostic_info | ||
| | 30 = @diagnostic_warning | ||
| | 40 = @diagnostic_error | ||
| ; |
There was a problem hiding this comment.
This simply does not hold for the trap produced by the c extractor, which produces severities in the range [0, ..., 5].
There was a problem hiding this comment.
Good point. This snippet comes from Ruby where we use this numbering scheme. In the end it does not matter too much which numbers are used. We could just as well adjust the Ruby extractor. If we can use the same numbers across languages that would be nice.
RasmusWL
requested changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.