Implement Concurrency7 package #799
Conversation
| not isExcluded(sink.getNode().asExpr(), | ||
| Concurrency7Package::timedlockOnInappropriateMutexTypeQuery()) and | ||
| Flow::flowPath(source, sink) | ||
| select sink.getNode(), source, sink, "Call to mtx_timedlock with mutex not of type 'mtx_timed'." |
There was a problem hiding this comment.
Add a message link to the source - perhaps make the link mutex in the message? Otherwise users have to know to click into the path viewer in GitHub to see the source.
| Expr mutexTypeExpr; | ||
|
|
||
| MutexInitCall() { | ||
| getTarget().hasName("mtx_init") and |
There was a problem hiding this comment.
Could mtx_init be a macro?
| exists(AddressOfExpr addrOf | | ||
| getArgument(0) = addrOf and | ||
| addrOf.getOperand() = addressedExpr and | ||
| getTarget().getName() = "__c11_atomic_init" |
There was a problem hiding this comment.
Is this name required by the standard? If not, we need to confirm it's used by all our supported compilers, or use a different approach (identify the function call wrapped by the macro atomic_init?)
| exists(ControlFlowNode missingInitPoint | | ||
| missingInitPoint = getARequiredInitializationPoint(v) and | ||
| not exists(AtomicInitAddressOfExpr initialization | | ||
| initialization.getAddressedExpr().(VariableAccess).getTarget() = v and |
There was a problem hiding this comment.
Do we need to consider non-local initialization? e.g. a function that takes the address and initializes the variable?
| }, | ||
| "queries": [ | ||
| { | ||
| "description": "Atomic objects that do not have static storage duration shall be initialized with a value or by using 'atomic_init()'.", |
There was a problem hiding this comment.
Consider adding an implementation_scope for this rule.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.