This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Pass progress object to TE clone. #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsExt.CloneAsync`. This was not easy before as the call to `CloneAsync` was hidden in the Clone button command in RepositoryCloneService. This commit: - Stops the `RepositoryCloneViewModel` from doing the clone itself - Adds a `DialogService` to show the clone dialogs and return their results - Adds a "progress" parameter to `RepositoryCloneService.CloneRepository` and `IVSGitServices.Clone` - Makes the connect and start pages use the dialog service to show the dialog and then call the clone service This commit also fixes #849: - `RepositoryCloneService.CloneRepository` and `IVSGitServices.Clone` now return a task that doesn't complete until the clone is complete - Changes `GitHubConnectSection` to have a `Clone` command which disabled itself while the clone is in progress.
The name was misleading: a normal clone can also be initiated from the start page, this flow is for re-cloning a previously cloned repository.
jcansdale
suggested changes
Feb 23, 2017
Collaborator
jcansdale
left a comment
There was a problem hiding this comment.
I'm afraid all clone seems to do for me is add the folder to the list of recent solutions/folders. It doesn't actually clone the repo. 😢
Contributor
Author
|
Uhh, not sure what's happened here, a load of changes aren't present! |
Collaborator
|
Seems to be working now! Is this the new progress bar? |
Collaborator
|
Unfortunately it hung near the end with the following: 😢
It then stuck like this when I tried to cancel: Have you been able to clone |
Contributor
Author
|
This seems to be a problem with VS2017 RC - it happens even when you clone from TE directly. |
jcansdale
approved these changes
Feb 24, 2017
Collaborator
|
Clone and re-clone seems to be working. 👍 from me! |
paladique
approved these changes
Feb 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #800, we need to pass a progress object to
IGitActionsExt.CloneAsync. This was not easy before as the call toCloneAsyncwas hidden in the Clone button command in RepositoryCloneService. This commit:RepositoryCloneViewModelfrom doing the clone itselfDialogServiceto show the clone dialog and return its resultsRepositoryCloneService.CloneRepositoryandIVSGitServices.CloneRepositoryCloneService.CloneRepositoryThis commit also fixes #849:
RepositoryCloneService.CloneRepositoryandIVSGitServices.Clonenow return a task that doesn't complete until the clone is completeGitHubConnectSectionto have aClonecommand which disabled itself while the clone is in progress.Also a small rename:
UIControllerFlow.StartPageClone->ReClone: The old name was misleading: a normal clone can also be initiated from the start page, this flow is for re-cloning a previously cloned repository.