This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Only show Sign in with your browser option for github.com
#2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hmm, I'm not sure this really adds much: my gaze is still going straight to the user/pass textboxes as that's what I expect from a login dialog. What about: when opening the dialog, show a button saying "Sign in with your browser", and below it a smaller link saying "Sign in with username and password" and only when you click that button the UI changes to display the user/pass boxes? |
Collaborator
Author
That sounds good. What to you think @donokuda ? Could you pick up where I left off on this PR? 🙏 |
Signing with with username/password is going away, see: https://developer.github.com/changes/2020-02-14-deprecating-oauth-auth-endpoint/
Sign in with your browser option for github.com
Collaborator
Author
|
Obsoleted by #2469 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In future only the
Sign in with your browser option will work(see here). We need to remove the user/pass/2FA UI.Sign in with browser is by far the easiest authentication method and should be encouraged where possible. In order to do this, we're placing it first in the list of login options (see #2194).
What this PR does
Sign in with browseroption above other optionsWhat this PR doesn't do
We considered only showing the
Sign in with browseroption when available. We decided not to do this for the following reasons.There might be times where it is necessary to log in using a token (e.g to push a GitHub Action)theworkflowscope is now being requested, see Request theworkflowscope #2462How to test
The GitHub and GitHub Enterprise logins should look like this:
GitHub
GitHub Enterprise
