This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Use VS2015 SDK tasks when StartProgram is VS2015 #1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally use `VisualStudio.Sdk.BuildTasks.14.0` when `StartProgram` contains the string `Microsoft Visual Studio 14.0`.
grokys
suggested changes
Jun 18, 2018
Contributor
grokys
left a comment
There was a problem hiding this comment.
This doesn't work for me in VS2017. I can confirm it works when running from the commandline with a StartProgram env var set, but it doesn't work from the IDE.
Automatically detect Visual Studio 2015 and set VisualStudioVersion property to 14.0.
Don't attempt to preload GitHub.VisualStudio.csproj.user if the user hasn't created one.
grokys
approved these changes
Jun 19, 2018
Contributor
grokys
left a comment
There was a problem hiding this comment.
Great! This works for me now!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR lets a developer use Visual Studio 2017, but set the
Start external programoption to the Visual Studio 2015 application. TheGitHub.VisualStudio.csprojbuild script will detect that an alternative start program is being used and use the appropriate targets files to install the VSIX in the experimental instance of Visual Studio 2015.VisualStudio.Sdk.BuildTasks.14.0whenStartProgramcontains the stringMicrosoft Visual Studio 14.0Questions
~~ This change will mean that the
VisualStudio.Sdk.BuildTasks.14.0script will only be used whenStartProgramhas explicitly been set. The newerMicrosoft.VSSDK.BuildTools.15.0script will be used, even when building with MSBuild 14.0 in CI. ~~~I believe most of us are now using Visual Studio 2017, so will have been testing this configuration. We should still check that nothing important has changed/broken in CI!
We'll probably want to move to using MSBuild 15.0 at some point.
I've had some issues with a corrupted MEF cache after installing in VS 2015. This is pretty normal though and quite likely nothing to do with this PR. Clearing the cache seems to fix it.