This repository was archived by the owner on Jun 21, 2023. It is now read-only.
TrackingCollection Fixes #1483
Merged
TrackingCollection Fixes #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly been processed
36ce232 to
6772f69
Compare
32b0866 to
65aa4f5
Compare
65aa4f5 to
9f3828f
Compare
Contributor
|
Alrighty, all the tests are happy. I found a couple of bugs with the handling of empty sources or slow sources, that's fixed. |
shana
previously approved these changes
Feb 13, 2018
Use 2 min default timeout in all unit test assemblies.
2258914 to
4ef92cc
Compare
Contributor
Author
|
Ok @shana made the timeout 2 mins for all tests - everything seems to pass now. |
shana
approved these changes
Feb 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a
TrackingCollectionbug where the OriginalCompleted observable would finish before all items have been processed and fixes a flaky test:StartsTrueBecomesFalseWhenCompleted.