This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Make sure we always create a valid index if the database has old/invalid json data #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lid json data Fixes #1319
jcansdale
approved these changes
Feb 1, 2018
Collaborator
jcansdale
left a comment
There was a problem hiding this comment.
I can confirm that it now creates a new index and the clone dialog is able to complete loading without crashing.
Looks good to me. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the database has json that we're not expecting in index entries, avakache throws a json deserialization exception, but I can't seem to catch it anywhere for some reason, which means it ends up returning a default
CacheIndexinstance with all empty fields, which meeeeans later on we crash trying to save it. So, make sure we always return a valid index.Fixes #1319