ToRepositoryUrl should never throw, it's a conversion helper #122
Conversation
There was a problem hiding this comment.
In this case, url is effectively null, right given the definition of IsValidUri.
There was a problem hiding this comment.
Yes, there's no real change between url != null and IsValidUrl, but it's more explicit what it's checking for (if it's a valid url that was successfully parsed from a string value).
And you never know, maybe the definition of what constitutes a valid url might change in the future ¯_(ツ)_/¯
There was a problem hiding this comment.
(i.e., it might be a non-null uri that's invalid for other reasons)
There was a problem hiding this comment.
I guess my point is does this change simply push the nullref exception further up the stack?
There was a problem hiding this comment.
Ah, no, all the callers are prepared to get a null back from this method, null is a valid return.
…ever-throw ToRepositoryUrl should never throw, it's a conversion helper
Fixes #121