Fix the contents function on the repository API. #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that Github either changed their way of querying files
or directory or the bug was always there but say you want to do :
repo.contents(branch, "MYFILE", function(err, contents) {}, false);
it currently doesn't work and list only the root directory of the
repository. Changing slightly the way Github.js query the contents
make things works correctly as expected.
|
+1 for this |
|
It is related to #92 |
Member
Member
|
Closing as duplicate of merged PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that Github either changed their way of querying files
or directory or the bug was always there but say you want to do :
repo.contents(branch, "MYFILE", function(err, contents) {}, false);
it currently doesn't work and list only the root directory of the
repository. Changing slightly the way Github.js query the contents
make things works correctly as expected.