Skip to content

Revert rust color change#4326

Merged
lildude merged 1 commit intogithub-linguist:masterfrom
0xpr03:patch-1
Nov 14, 2018
Merged

Revert rust color change#4326
lildude merged 1 commit intogithub-linguist:masterfrom
0xpr03:patch-1

Conversation

@0xpr03
Copy link
Copy Markdown
Contributor

@0xpr03 0xpr03 commented Nov 13, 2018

The previous change #4319 made it hard to distinguish the language and made it hard to recognize for all users that are used to the old color. Practically speaking the change introduced more problems than the esthetics it wanted to solve gained us. Also esthetics are personal opinions, so I'd leave a new color up to the rust team to decide.

The previous change made it hard to distinguish and made it hard to recognize for all users that are used to the color. Practically speaking the change introduced more problems than the esthetics it wanted to solve gained us.
@atouchet
Copy link
Copy Markdown

I am in favour of this. As has been mentioned in the comments of #4319 the deeper red colour is harder to distinguish from other languages (D, Ruby, Scala, etc.) while the original colour worked just fine. Also I do not believe that the #a62c00 shade has any real association with the Rust community.

@coder543
Copy link
Copy Markdown

FWIW, I started a humorous thread over here discussing the change. It seems like most people favor the old color, although I don't have as strong of an opinion on this subject. I slightly favor the old color.

@xtian
Copy link
Copy Markdown

xtian commented Nov 14, 2018

I am in favor of this as well. The color that people would most associate with Rust would be that of its unofficial mascot, who is orange: http://rustacean.net

Additionally, the rationale that the old color doesn't look like iron oxide is misguided since the language was named after the rust fungus, which also has an orange color: https://en.wikipedia.org/wiki/Rust_(programming_language)#History

@meme
Copy link
Copy Markdown

meme commented Nov 14, 2018

I, too, prefer the older colour. Please bring it back. Annoying that this change was done without the O.K. of the Rust team.

@quininer
Copy link
Copy Markdown

I think Rust color is a better choice.

@amatuni
Copy link
Copy Markdown

amatuni commented Nov 14, 2018

I think the new color is 10000x better than the old one. The color suggested by @quininer could be a nice compromise though.

@CharlotteMoore927
Copy link
Copy Markdown

the new colour is great and definitely better than the old one!

@gralpli
Copy link
Copy Markdown

gralpli commented Nov 14, 2018

It was a breaking change. We could revert it and then gradually change it to the new color over time, so no one will notice and/or complain (remember eBay, anyone?) 😅😋

Copy link
Copy Markdown

@VitalyAnkh VitalyAnkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good.

@elpiel
Copy link
Copy Markdown

elpiel commented Nov 14, 2018

I am in favor of the old one as well. It's too dark and distinguishable from other languages.

@lildude
Copy link
Copy Markdown
Member

lildude commented Nov 14, 2018

I'll try get this out today.

@lildude lildude merged commit 8ad9e5f into github-linguist:master Nov 14, 2018
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Nov 14, 2018
@lildude
Copy link
Copy Markdown
Member

lildude commented Nov 14, 2018

This is now live on GitHub.com.

@0xpr03 0xpr03 deleted the patch-1 branch November 18, 2018 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.