Repository navigation
Conversation
…lates The `# repository:` comments above KIND_VERSION, KUBERNETES_VERSION and KYVERNO_VERSION match no manager, so those pins never move. Convert them to the standard `# renovate:` annotation and widen the annotation manager to every generator template, both the `NAME ?= value` and the `NAME: value` form. The hardcoded KYVERNO_VERSION manager becomes redundant and goes. Towards giantswarm/giantswarm#37619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
# repository:comments aboveKIND_VERSION,KUBERNETES_VERSIONandKYVERNO_VERSIONmatch no manager, so those pins never move. This turns them into the standard# renovate:annotation and widens the manager from #2753 to every generator template, so the hardcodedKYVERNO_VERSIONone can go.kind and
kindest/nodebump in one PR, as they are only tested as a pair.This changes
Makefile.gen.chainsaw.mkandtest-kyverno-policies-with-chainsaw.yamlin every kyverno-policy repo on the next align-files run.Towards https://github.com/giantswarm/giantswarm/issues/37619