Repository navigation
fix(search-events): Say when Sentry skipped validateSearch - #2242
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Sentry's events/validate endpoint only checks RPC datasets. For errors it returns valid with a "not compatible" dataset note and checks nothing, but the embedded agent's validateSearch tool reported "Search validation passed." The agent then trusted queries with invented project: filters or unsupported functions such as latest(id), and the real /events/ call returned 400. Report the skip, and name what went unchecked. Also tell the agent that service, app, and host names and issue short IDs are not projects, and that a project scope from the request is already applied. Refs #2173 Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the open
validateSearchhalf of #2173.organization_events_validate.pyin getsentry/sentry checks only datasets inRPC_DATASETS. For errors, it returns early withvalid: trueand the dataset note "This dataset is not compatible with the validate endpoint, your request may still be valid". The embedded agent'svalidateSearchtool reported that as "Search validation passed.", so the agent used queries that no one had checked, and the real/events/?dataset=errorscall returned 400.User feedback MCP-SERVER-GPS shows two
search_errorsfailures that got through this way:project:filter. The call failed withProject(s) … do not exist or are not actively selected. The reporter says this happened even withprojectSlugset.latest(id)as a field. The call failed withlatest is not a valid function.Changes:
validateSearchnow says validation was skipped and that fields, functions, and filters, includingproject:, were not checked. It still returnsvalid: true, because otherwise the agent could never finish an errors query.project:only for a Sentry project the user calls a project. Service, app, and host names, and issue short IDs, are not projects. A project scope passed with the request is already applied.A regression test covers the skipped-validation response.
Open decision: the prompt rule has no eval case yet. Should one be added before merge? The deeper fix is for
/events/validate/to support the errors dataset. That belongs to the Explore/Discover owners in getsentry/sentry, not to this repo.via Sentry.
--
View Session [Sentry]