Skip to content

Share OAuth device polling intervals between CLI and MCP - #1423

Merged
BYK merged 1 commit into
mainfrom
feat/toolkit-core-oauth-poll
Oct 6, 2026
Merged

BYK merged 1 commit into
mainfrom
feat/toolkit-core-oauth-poll

Conversation

@BYK

@BYK BYK commented Oct 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Move the RFC 8628 pending/slow-down interval rule into @sentry/toolkit-core/oauth-poll and use it in both device flows.
  • Keep each product's deadline, transport, response validation, errors, and token storage unchanged.
  • Add a timed CLI polling regression and shared rule tests; retain MCP's device-flow coverage.

Part of #1469.

Validation

  • pnpm run tsc and pnpm run lint passed after generating the ignored CLI API schema.
  • Full CLI suite: 10,460 passed / 16 skipped; MCP-core: 1,753 passed / 6 skipped; MCP server: 83 passed; MCP test client: 80 passed; Cloudflare: 433 passed; toolkit-core: 10 passed.
  • Root script tests: 30 passed. CLI Biome, Oxfmt, generated-file and docs-link checks passed.
  • The aggregate pnpm run test reached the 15-minute shell limit after the CLI suite; all remaining package suites passed when run separately.
  • After fast-forwarding to current main, focused CLI OAuth + short-ID tests (24), MCP device-flow tests (7), toolkit-core (10), CLI typecheck, lint, and generated-file checks passed.

Co-Authored-By: GPT-6 Sol <agent@openai.com>
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Oct 6, 2026
@BYK
BYK requested a review from betegon October 6, 2026 10:40

@betegon betegon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cooooool!

@BYK
BYK merged commit cd77d93 into main Oct 6, 2026
30 checks passed
@BYK
BYK deleted the feat/toolkit-core-oauth-poll branch October 6, 2026 14:39
joshuawayzwright pushed a commit to joshuawayzwright/sentry-mcp that referenced this pull request Nov 16, 2026
## Summary

Fixes getsentry#1423.

- Preserve HTTP status text from API responses.
- Report useful status and request context when a non-2xx response has
an empty textual body.
- Keep JSON responses machine-readable with a `{status, statusText,
body}` envelope while applying `--fields` to the API body.
- Preserve raw binary successes and summarize binary errors without
emitting response bytes.
- Classify every status outside the 2xx range consistently, including
3xx responses.

## Verification

- `pnpm exec vitest run test/commands/api.test.ts test/e2e/api.test.ts`
- `pnpm exec vitest run test/lib test/commands test/types test/script
--coverage`
- `pnpm run typecheck`
- `pnpm run lint`
- `git diff --check`

The package `test:unit` wrapper failed before reporting results with
`Unknown: ChildProcess.kill`; the equivalent direct Vitest command
passed 9,243 tests with 16 skipped.
joshuawayzwright pushed a commit to joshuawayzwright/sentry-mcp that referenced this pull request Nov 16, 2026
## Summary

Fixes getsentry#1423.

- Preserve HTTP status text from API responses.
- Report useful status and request context when a non-2xx response has
an empty textual body.
- Keep JSON responses machine-readable with a `{status, statusText,
body}` envelope while applying `--fields` to the API body.
- Preserve raw binary successes and summarize binary errors without
emitting response bytes.
- Classify every status outside the 2xx range consistently, including
3xx responses.

## Verification

- `pnpm exec vitest run test/commands/api.test.ts test/e2e/api.test.ts`
- `pnpm exec vitest run test/lib test/commands test/types test/script
--coverage`
- `pnpm run typecheck`
- `pnpm run lint`
- `git diff --check`

The package `test:unit` wrapper failed before reporting results with
`Unknown: ChildProcess.kill`; the equivalent direct Vitest command
passed 9,243 tests with 16 skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants