[kunal649]

Why:
fetch('') is instrumented, but xhr.open('GET', '') was not, and once an empty URL request is instrumented its breadcrumb shows url: "". This PR fixes both

• xhr.ts bailed on !url, which treats an empty string like an unparseable argument, so empty-URL XHRs got no breadcrumb and no span. It now only bails on url === undefined, so XHR matches fetch.
• The fetch and XHR breadcrumb handlers now show the page URL for an empty URL instead of "". Query and fragment are stripped with stripUrlQueryAndFragment, so params like ?token= from the page URL don't end up in breadcrumbs. Since an empty URL resolves to the page URL itself, the helper uses location.href directly instead of calling new URL() (bcoz its throws for hrefs like about:srcdoc). without a location object (e.g. workers), nothing changes.

Only empty URLs are rewritten, absolute and relative URLs keep their current breadcrumb behaviour.

How to review:
Start with:

• packages/browser-utils/src/instrumentation/xhr.ts
• packages/browser/src/integrations/breadcrumbs.ts

and the regression coverage in:

• packages/browser-utils/test/instrumentation/xhr.test.ts
• packages/browser/test/integrations/breadcrumbs.test.ts

The key things to check are that only empty URLs are rewritten, and that the query and fragment are stripped from the page URL in all three breadcrumb paths (fetch, failed fetch, XHR).

Unsure about:
Whether relative URLs (like /api/foo?x=1) should also be resolved against location.href and stripped in breadcrumbs. I kept this limited to empty URLs so the change stays scoped, but yeah I'm happy to widen it.

Ref #13168

[s1gr1d]

Thanks, the XHR fix looks good!

Regarding your "Unsure about": let's keep it to empty URLs

[s1gr1d]

filterCollectedUrl already filters sensitive params (e.g. token=[Filtered]) based on dataCollection.urlQueryParams.

We could only drop the fragment and let filterCollectedUrl handle the rest.

Suggested change

	function getBreadcrumbUrl(url: string): string {
	const pageurl = url === '' ? WINDOW.location?.href : undefined;
	return filterCollectedUrl(pageurl ? stripUrlQueryAndFragment(pageurl) : url);
	}
	function getBreadcrumbUrl(url: string): string {
	const pageurl = url === '' ? WINDOW.location?.href : undefined;
	return filterCollectedUrl(pageUrl ? pageUrl.split('#')[0]! : url, client);
	}

[kunal649]

okay!

[s1gr1d]

Some test nits:

• consider using toHaveBeenCalledWith instead of mock.calls
• restoreAllMocks instead of resetAllMocks, and unset the client after each test

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 149a4b3. Configure here.}

[kunal649]

your bugbot scares me off @s1gr1d